Has for rent been fixed yet?

No, it hasn't. They did fix an issue where residential rental lots got stuck as rentals. They now can be changed to other lot types with no problem. However, the lot name bug they said they fixed wasn't. Right at first it seemed to be partially fixed; the rental lot name would stay what you named it, but the unit names would revert. As time has gone on, I've noticed that the names of my rental lots have also reverted. 

All that said, I love the world and BB. I love that I was able to bring rentals from Belladonna Cove into my game. I keep a note on my phone with the names the game has given my rentals and the name I want them to have, so I can fix it if they ever actually fix the bug. I don't regret buying the pack, but I do wish I'd bought it on sale like the others.

I don't regret my purchase of For Rent but I wish I had bought it on sale. 

I learned from For Rent to not pay full price on a new EP.

I needed some new gameplay and rushed into buying the EP. 

For Rent is a vacation destination in my game because I don't trust the rental gameplay yet, which is what I paid for.

To get an overview of the state of the pack you might have a look at this AHQ post, which shows a compilation of all open issues reported in connection with the For Rent EP:

https://answers.ea.com/t5/Bug-Reports/READ-FIRST-Compiled-list-of-reported-Issues/m-p/13277181/highlight/true#M262242

I guess the sections which refer to the owner tennant gameplay are of greater interest:

• Bills/Money/Royalty
• Property Manager
• Rental Event
• Residential Rental

Those sections contain some of the EP's widely known and stll open issues.

Note that these issues refer in general to an unmodded game. If you use mods, there might be more/different issues.

My personal opinion: Tomarang is a nice world, the BB stuff is good. CAS items are not as colourful as expected. The night market is a disapointment: pretty orphaned, only 4 stalls are functional, the rest is set dressing. The tiger sanctuary, the fish market and the temple are rabbit holes. I never touched the For Rent gameplay due to all the associated problems. I bought a  code at a key reseller with a reasonable discount (50% off), but I wouldn't recommend it for the full EA price.

.......... ... .. .... ..... ...  .

no it is not fixed. the bugs i currently expirience as of December 9th 2024 are:

I cannot collect rent. have never seen a penny in my life over multiple saves. i make a new save with this pack every few months bc it makes me actually interested to play and this always kills it immediately 

if that doesnt kill it, my residents are permanent. the contracts auto renew at the start of the week every week. now this is new actually, originally in my first playthrough i thought this was a bug until i was patient and it reset to where it should correctly be, but this playthrough no it just renews the contract and counts down again and i can only unjustly evict my tenants.

i also cannot complete the landlord events as when something like a fridge breaks, and im given the option to repair or replace, if i replace it i auto fail the mission :)

not the only pack i could make a list of like this sadly, extremely disappointing to hear they think they can fix a fundamentally broken game and expect customers to buy broken packs forever instead of making a new game.