This is exactly what's happening to my game too. Starting since the August major patch.
I had perfectly working mods and game before that patch. But ever since that August patch, screenshots would crash the game. There's no "if". It's about "when" and usually it's anything between 1 - 60 seconds.
I thought it was some mods causing problems, when I had updated some of them after the August patch (I had already removed those mods which hadn't got updates). But after I had checked the mods, and the game was still crashing, I did these things...
1. removed every single mod.
2. removed all the cache files, client DB file, all the screenshots!
3. Removed all the mod related files from the save folder and even removed older save files, only leaving the new save files I needed to test the game.
4. Then repaired the game.
5. Loaded the game, and created brand new save file with two brand new sims, making a "start" save file, and then quitting the game, and then reloading the save and playing it for couple of minutes, and then saving another save just to be sure that I would have completely clean backup save for testing just in case something would happen to the test save.
I played with that back up testing save file about a hour, without any problems (not saving it), going through the "in-game tutorial" missions and talking to NPC sims. I didn't travelled to another world, nor lots!
Then, I pressed C to take a screenshot and I was pressing the C several times, to take well over 25 screenshots, while moving the "camera" around my sim. Game was paused while I did it. I noticed that before the crash, several of the pictures which should had been saved, weren't saved and there were only 25 pictures in the screenshot folder. I can't say what's the exact timeline, few seconds, five seconds etc, when the game didn't saved the screenshots anymore.
6. I then removed the screenshots, and then I reloaded the clean back up save again.
7. I didn't played with the testing save. Within few minutes since reloading it, just to made sure that there's nothing loading anymore (like NPC sims appearing), I pressed C once, and immediately the game crashed. There were no screenshot in the screenshot folder! The game hadn't saved the screenshot!
I reloaded the save again, tested that few times with unpaused, paused, with similar results = game crashing.
I also tested the screenshot with both the window (where you can see what the screenshot looks like) and without it, but there was no difference = game would crash.
I also tested it with windowed (full screen) and also full screen mode. No difference. Warning to people who are testing their game, if you have full screen mode, you can't Alt Tab out of it, you have to restart your computer!
I also tested it travelling to another lot in the same neighborhood, and then also to another world, and it didn't matter, the game will crash when pressing C
My game crashes by first freezing. I can hear soundfiles (like sim speaking) playing through, then quiet. Then the mouse pointer goes "blue round", like it's loading something. Then when I press the mouse key, it makes the screen see-through white, and brings up the Windows window saying that the app doesn't respond, and the how I can lose information if I don't wait it and the blue round changes back to regular mouse pointer. Of course there's no point to wait because the game isn't running. (I did waited first time, for several minutes, just to check that the game indeed crashed and wasn't loading anything.)
-All the drivers are up to date, also the windows 11 is up to date. I've restarted computer few times too, so there's no background stuff going on. It's not the Steam version. I checked the Windows Event Viewer, but there's nothing there, just that the app crashed. I can assume that even though there's not too many people complaining about it, it's just because they aren't taking screenshots.
9. I tested it with the dx9 and the game run just fine, taking several screenshots, both unpaused and paused (no mods). However, I haven't tested to play the game for longer time, so I can't confirm if the crash would appear later.
10. I changed it back to dx11 and after about 30 seconds, after taking several screenshots, the game again crashed. Also, there were 10 screenshots only, but as you can imagine, taking screenshots within 20 seconds (I had a pause for first 10 seconds) I took many more than those 10 screenshots!