@fergalicious214 , you need to make sure that Windows is set to "Save to Computer by default" so that the game will properly save your games in the correct place. Otherwise, it will continue to "save" games to OneDrive or at least look to save them on OneDrive. This has been the problem with many games for both the Windows and Mac OS since OneDrive and iCloud were introduced.
So go into Documents > EA Games > Sims 2 and make sure the game folder is set to "Save to Computer by default". (If you are playing on Origin, check the Origin preferences to insure they also save to your hard drive and not to "the Cloud".)
I found some steps online to take to insure that the game is saving in the correct place.
1. Open an existing document or create a new document. (in this case check the Sims 2 folder itself)
2. Click File in the top-left portion of the window.
3. Once you’re on the screen where you can see your existing documents, click Options.
4. In the Options windows, select Save from the list of options on the left.
5. To remove OneDrive as the default save location, find and check the box labeled Save to Computer by default. The default save location is your user Documents folder. (EA Games)
6. If you do not wish Documents folder as your new default save location, you may choose to set a custom save location.
7. Click Browse button next to the Default Local File Location box and navigate to the desired location on your PC.
8. When you’ve made your selection, click OK to save it.
9. Click OK again to close the Options window.
10. After doing the following steps, you may need to restart the Game for it to take effect.
You should also check your Neighborhood folders as well and make sure they are "Save to Computer by default" to be sure.
Please let us know if this works for you.