@thedirectorlives
I recall the "Manage Households" pop-up to move Sims between households when a Sim marries another Sim outside of the household, but I don't recall there ever being a "change Sim's surname" option and I've been playing this game for something like eight years. Maybe it was a limited roll-out test, or just a short-lived console thing like crinrict said? I found a few old videos of TS4 weddings from the timeframe you mention, but they don't show this pop-up (though it is a PC video, so if it was a console-exclusive thing like crinrict suggested then it wouldn't show up anyway). I'll keep looking around, though, I'm curious if anyone else remembers this menu option.
Hi! I'm SimmerStar4 (they/them). I'm not an expert on game issues, so don't take me as one! I'm just a Sims player who wants to try and help fellow players, and who finds game bugs and issues interesting.