Are these photos lost forever?

If you have an earlier/back up save which has them in, try going into that save and saving those photos in a room, then upload the room to your library. Keeping photos in your sims inventory can also help to prevent them turning black.