That is interesting...
One thing about those roles you brought out (Gym Trainer and Bartender) is that these roles should prefer using sims that live in the same world or are evicted from there. They somewhat still prefer, as when I made some sims to be Tomarang and Chestnut Ridge locals, they were chosen as bartenders fine. Yet the other worlds still had a chance of recruiting them as a bartender. So yeah...
So Get Famous breaks that filter term then, having the game recruit sims that are not "living" in that world... Interesting... Both of the sims brought out in the example are unemployed (they do not need a career to appear in their original role), so simply giving sims a job should prevent them from randomly becoming a bartender.
Theory why it might break the filter term? Hmm... Both Gym Trainer and Bartender roles exclude famous sims (at least 1 fame level and they're out). Yet the template making them does not guarantee that new sims generated have exactly 0 fame points. Yet at the same time, I don't see more famous sims generated...
The only theory I can suggest here is that the game creates a sim with some fame points (but not enough for the 1 rank), gets excluded from the filter, and a pre-made sim without any fame levels is chosen. While I doubt that is the case, the reason must be hidden within the fame system...
About the world locals concept, it's another big thing that I plan to discuss in your thread as well. But for this part, only some worlds prefer choosing (or making) sims from the same world. Tomarang and Chestnut Ridge are examples of them. Other worlds aren't strict in that rule even without Get Famous.
The most priority factor about generating townies from my experience is "creating locals of the world which has strict local limits first". We can see many Japanese because both San Myshuno and Mt.Komorebi use it.
Back to the NPC roles, you said right that sims who already have a job should avoid being added new NPC roles. I think about giving high school teachers to get education job. But some sims shouldn't be touched.
For your information about fame points, I saw you write about this as criteria for role assigning. It may be another factor too. Or Get Famous gives a whole new rule about role-giving. I can't do mod or using program to see game code, I can only observe from my playing.
I currently disable Get Famous, so my knowledge is based on "all packs except EP06". But I sometimes enable it to test some mods.
I also found that some mods that work about townies and assigning roles can't work properly (or work differently) without "Get Famous" (such as Bienchen's townieoverhaul_lessfame). It would be something about the code that is included in this pack.
