Usually make 3 to 5 outfits in most categories (usually leave it at one swimsuit and one fitness outfit).
Only ever change their clothes out at times when I think it's time for a change or a new pack comes out with some brand spankin' new clothes that might fit a certain sim. I know I give townies at least another outfit or so, just to change things up a bit.