Traits should have an impact on bad emotions taking over good emotions or not and vice versa

This. And traits should also dictate how a sim reacts in certain situations. Like a hot-headed sim should be angry in situations where others are sad. Maybe cheerful sims should have a "Find the bright side" interaction that can lower their sad moodlets and/or give them a happy moodlet.