Crafting Items

I'd say wait as long as possible, and then craft whatever you can. The odds of coming up with donuts in a treat bag are always kind of low, so I wouldn't bother doing that unless you're just a few chocolate bars away from a particular prize.

And yeah, leftover treats and protein strings probably will just vanish after the game updates.