Scavenger Rey is a great example. Let's put her in a comp under JTR with bb8 and C3p0.
Because she's an agility attacker she will get 13.5% cd from relics, 30% from JTR lead, 50% from ID, 42% from a triangle, and 40% from C3p0 and translation giving her 325.5% cd before the set. 355.5/325.5=1.0921658986175115207373271889401 So in this scenario Scav Rey is getting at most a 9% increase in overall damage from the critical damage set (at 100%cc it will be 9%).
An offense set with absolute max offense secondaries on Scav Rey would represent a 77.33% increase in offense over her base offense giving the offense set a value of 8.4586923794507040079950233321218% which is still lower than the crit damage set so I retract my earlier statement about levels of crit damage outside of the set.
Even at 325.5% cd on scav rey it is possible for the crit damage set to produce more damage than the offense set so it's probably better to just run the calculations.
Weird fun facts: The fewer offense secondaries you have, the higher the value of the offense set, but the more cc secondaries you have the more likely the cd set is better.
This means that the offense set is going to be better in general for more starting players and the crit damage set is going to be better in general for more advanced players.
