it's interesting too in that scenario that the crit damage set is only barely better than the offense set, and it basically comes down to the offense secondaries.
Those are the absolute maximum offense secondaries you can get, so realistically most people will find the offense set better in that scenario regardless of crit chance. Because by absolute maximum I'm talking perfect procs and every proc being maximum.
The biggest impact on the % damage increase for the offense set is starting offense. The bigger it is, the smaller % of offense the flat secondaries will add up to which means 15% of base is a larger slice of the whole as the only % that varies is what the flats add up to.
For fun, I'm going to determine the highest and lowest % an offense set could be. To do so I am going to use the highest and lowest final offense stats I can find on swgoh.gg. So emperor palpatine has 6201 special damage, and Darth Maul has 1142 special damage (not sure if Maul uses special damage, and I don't really care. just going for the biggest and smallest numbers).
Max primaries and secondaries is worth 50.88% and +897. In Rey's case, that +897 translated to close to 25% of base. In Maul's case it is a much larger chunk: 78.546409807355516637478108581436% of base. This makes an offense set worth 171.3 special damage or a 6.538044165270764339728530330113% increase in special damage.
In Palp's case flat offense is a much smaller chunk of the whole: 14.465408805031446540880503144654% of base. This makes an offense set worth 930.15 special damage or a 9.071918058328058814937436097181% increase in special damage.
So now we know the ranges it is possible for an offense set to fall into with the absolute maximum offensive secondaries. 6.5-9%. Of course most people won't have offense secondaries anywhere near that good (if anyone actually even does) so numbers in the realm of 10% damage increase seem a fairly reasonable estimate for a very offense heavy offense set on someone you'd actually want to stack offense on.
