I'm going to do a simple walkthrough of a character to illustrate exactly how to determine which set is better in general for a character.
Let's use Chirrut as an example.
Chirrut has 3073 physical damage. 185 of that is from G12 gear. This is all the character info I need to determine if crit damage can be better and when it will be if it can.
Using current mod bonuses I can get Chirrut 6 secondaries of about 150 flat offense, 3 primaries of 5.88% offense, and 3 secondaries of 1.5%. So he can end up with an offense of (3073 - 185) * (1 + ((10 + 5.88 + 5.88 + 5.88 + 1.5 + 1.5 + 1.5) / 100) + 900 + 185 = 4900 physical damage we can get him to with mods. This is pretty much as high as he can get currently before in match effects are counted. of his 4900 physical damage, only 288 of it is coming from the offense set. So to determine the % damage increase of the offense set we take 4900 / (4900 - 288) = 1.062
In this instance the actual % increase the offense set provides is 6.2%
Now a crit damage set will provide 216/186 = 1.161 a 16.1% potential increase in damage. Now if I take the offense set damage and divide it by the crit set damage, I can see what % of damage the offense is responsible for compared to the crit damage set.
6.2 / 16.1 = 38.5 %
The offense set provides only 38.5% of the damage the crit damage set does. This means that as long as Chirrut crits at least 38.5% of the time, the crit damage set will be at least equal to the offense set. Chirrut has a base crit chance over 40% though, so at no point would an offense set benefit him over crit damage if offense stats are maxed on the gear under the current system. Now let's reexamine this using the incoming system.
The offense will be (3073 - 185) * (1 + ((15 + 8.5 + 8.5 + 8.5 + 4.5 + 4.5 + 4.5) / 100) + 990 + 185 = 5622 The offense set provides 433 of this physical damage.
5622 / (5622 - 433) = 1,083
The offense set is providing an 8.3% increase in offense with maxed offense in the new lineup.
Crit damage? 222/192 = 1.156
It's worth 15.6% offense now.
8.3/15.6 = 0.532
Under the new system it would take 53.2% crit chance for the crit damage set to be better IF you stack offense on Chirrut in every single nook and cranny. This could actually be reachable since a crit chance set can provide 8% crit in the update, but this is only with absolutely maxed offense. You can bring it down to 53% crit with maxed offense from mods (which greatly decreases the value of the offense set). In general it will be around 75% crit chance as the breakpoint.
