Issues with Manage Inventory Primitive on Legacy Collection and Abduction

I saw that user paradoxcase on Tumblr shared a post that was created after speaking with well-known community member Lazy Duchess and I wanted to share it here as the logic makes sense and I believe it's worth having the Sims 2 Legacy team look into it.

While not official, there have also been issues with the Community Time Project mod (issues that didn't exist in the Sims 2: Ultimate Collection) and I believe that may be related to paradoxcase's post.

Original Tumblr post here: https://www.tumblr.com/paradoxcase/774394433991032832/right-so-after-reading-some-error-logs?source=share

Right, so, after reading some error logs, obtaining a copy of the objects.package that shipped with the Sims 2 rerelease, and talking about this with Lazy Duchess, I have a conspiracy theory about why the rerelease is so **bleep** broken

So first, I looked at an error log that was happening in the Enthusiasm Tracker. It was coming from the function that signs sims up for a magazine subscription after they choose that option on the phone. It's a very short function, all it does is 1) check to see if the family has a magazine subscription token, 2) create one if it does not already exist, and 3) set a property on the token regardless of whether 2 was necessary or not. All three of these actions make use of the Manage Inventory primitive, which controls not just sim inventories, but also tokens like this, memories, and gossip. I compared all like five lines of this function to the one in my objects.package, that I have from the Ultimate Collection, and they were exactly the same. But for some reason, in the rerelease, this throws an error. There is no explanation at the level of this function. I kind of scratched my head and thought, maybe they changed how the magazine subscription token works in this version, and forgot to update this function? Or something?

Next, there was an Too Many Iterations error log that had a very obvious cause: for some reason, the active family had over 500 tokens in its inventory. The family inventory isn't listed in the error log, so have no idea what those tokens were, or how there came to be 500+ of them. BUT. The aforementioned magazine subscription token is a token that goes in the family inventory. Maybe these two problems are somehow related. Are those 500 tokens all magazine subscription tokens, or something?

And then there is the infamous error that the game now throws when a sim goes to get abducted. I didn't see an error log for this one, but I was making a post on MTS listing all of the known issues with the rerelease, and someone mentioned there that the issue is not so much with the abduction as it is with other sims reacting to the abduction, and if there are no sims on the lot to react to the abduction, the error does not occur. Someone else then mentioned that the Abduction Reaction Fix mod that I made actually fixes this error. I made that mod, I know exactly what it does. What does it do?

Well, you see, objects in the game all have what is called a tree table, which is a table of interactions and the functions that need to be called when those interactions are triggered. One of the interactions on the telescope is the interaction to run to the telescope after someone has been abducted. But, in the Free Time expansion, a lot of new interactions were added to the telescope, and for some reason, EA decided to renumber all of the functions when they did that. They forgot to update the tree table, which references functions by their numbers, and as a result, the function that was called when sims were supposed to do the run-to-telescope interaction was actually the function that gives sims credit for discovering a new planet. In my mod, I fixed this, so that when sims are supposed to run to the telescope, the proper run-to-the-telescope function is called instead.

So, the error happens when my mod is not installed (when the planet discovery function is being called erroneously) and not when it is (when the run-to-the-telescope function is called instead). So the error must be coming from the planet discovery function. What is in the planet discovery function? It is almost identical to the magazine subscription function. It checks for the planet discovery token, adds it if it isn't there, and then modifies a property on it, using Manage Inventory. So this is exact same bug. And other people are reporting that some sims cannot gain memories - another game function that is handled by Manage Inventory. There is also an error that happens after a sim cooks food - one thing that happens at that point is that tokens and memories are added to the sim's inventory marking that they have successfully (or unsuccessfully) learned to cook that food.

So at this point, my theory is that EA somehow broke the Manage Inventory primitive. It's used all over the code, to do all sorts of stuff, if you break something that ubiquitous and fundamental, of course it's going to cause a whole lot of seemingly completely unrelated errors. Manage Inventory is now going hog-wild, throwing errors, adding hundreds of extraneous tokens to inventories, refusing to give sims memories, and who knows what else. I can feel it, this is the answer