Interesting idea, but I have some critiques:
Public Enemy: Neat really does not hinder this one. Irl, being able to clean up after yourself is very desirable trait if you're in the habit of committing crimes. In Sims 4, it doesn't make a difference. Proper, on the other hand, is a terrible trait to have if you're working on the Public Enemy aspiration. Loner is also not ideal, given that the aspiration requires a lot of social interaction.
BodyBuilder: Glutton is actually a really good trait for this aspiration, helps them stay on top of their hunger needs, given how many "calories" they burn. Lactose and Vegetarian are bad for this aspiration, because they limit the person's eating options. Non-committal doesn't really affect this aspiration that much, but adventurous does. Adventurous sims get bored from working on the same skill over and over. Adventurous is actually bad for most skill-based aspirations.
Fabulously Wealthy: Freegan is the worst trait for this aspiration. Child of the Ocean might be inconvenient because of the urge to go off on a beach trip instead of work.
