Does the butler actually clean anything that needs to be cleaned?

Yes. the butler will clean what needs to be cleaned. But remember the butler is not a robot with no needs, it is a sim with needs. Therefore, it will take priorities and leave the rest for later. I found it best to let the butler do what it wants. If I REALLY need something accomplished I will have a sim do it but this tends to be rare with the butler.