def get_objects_of_def_id_gen

"IngeJones;899528" wrote:
Is the following function referring to the object Tuning IDs? And if so, please could you give me an example of use since the existing decompiled scripts don't seem to use it at all.

def get_objects_of_def_id_gen(self, *definition_ids):
for obj in self._objects.values():
while any(obj.definition.id == d_id for d_id in definition_ids):
yield obj

Yes, it is, however you should verify the context of 'self' - I'm assuming that it's the object_manager, and in that case it should return the definition resource list.

"IngeJones;899528" wrote:
Is the following function referring to the object Tuning IDs? And if so, please could you give me an example of use since the existing decompiled scripts don't seem to use it at all.

def get_objects_of_def_id_gen(self, *definition_ids): - defines function "Get all objects within ID list definition_ids"

for obj in self._objects.values() - Loops the loaded resource array for the manager.

while any(obj.definition.id == d_id for d_id in definition_ids): - While definition.id of obj in array matches any id in list definition_ids, (you can change this to an if statement if you wish)

yield obj - yield object (The output of the function will be the array of object instances with matching definition ids)

Just loop the output and do whatever you desire with the instance array.

There are many ways to get these lists and instances however it would be easier to use the object and instance managers if you already have the definition ids and you can create your own array. You should test the resource lists if you want to understand the managers and how to fully utilize them.

The simpler equivalent of the above would be the following:

obj_manager = services.object_manager()
definition_ids = 
obj_list = []
loaded_obj_list = obj_manager.get_all()
for obj in loaded_obj_list:
     for definition_id in definition_ids:
          if obj.definition.id == definition_id:
               obj_list.append(obj)
return obj_list

If you only want to work with tuning then the following will be the equivalent however you will need to instantiate the objects:

instance_manager = services.get_instance_manager(resource_type)
tuning_instance_ids = 
tuning_list = []
for tuning_instance_id in tuning_instance_ids:
     tuned_instance = instance_manager.get(tuning_instance_id)
     if tuned_instance:
          tuning_list.append(tuned_instance)
     else:
          output("The manager did not return a tuning instance for id " + repr(tuning_instance_id))
return tuning_list

Thanks, I'll see how far I get with the above, and come back if I get stuck :)

"IngeJones;15188617" wrote:
Thanks, I'll see how far I get with the above, and come back if I get stuck :)

If you're going to work with the full object list or any of the resource lists, I'd recommend writing them to a file since the console won't handle more than a few hundred lines before it begins to hang the engine and file.write is good for debugging as well (obviously).

file_path = "C:\\Projects\\TS4"
output_file = open(file_path + '\\filename.extension', 'a')
output_file.write("This is a test file.\n")
output_file.close()

I'd recommend not opening and closing files during loops but obviously you can write as frequently as necessary.

Also, I've neglected to correct an error in the previous post, however I know that you'd see it immediately so I assumed that you would just laugh at it. For the instance manager example, use the tuning_instance_id from the loop to get the tuning instance rather than tuning_id which has not been defined, and don't indent the if statement.

The resource type list can be found within Core\Sims4\resources.pyo

In fact I only need to find objects matching *one* object tuning file. And it would be on a single lot. It's just that at the moment the EA code looks for specific GUIDs while I feel it should check for any object of that type. Well basically it's to change the python code so that when a sim has a baby it recognises CC bassinets as bassinets. Currently it's hardcoded to specific catalog GUIDs - pertaining to the 4 colorways of the EA crib. Ideally EA would change this themselves, it didn't really make sense to do it that way. Unless I am missing some point.

Lol this was a bit of a disaster. She went to the custom crib to give birth, so that bit was ok. But as soon as the baby was born the crib vanished, with the baby showing as a memebr of the family, but absolutely no way of finding the baby!!

Later: Oh... after swapping to another household and back again the baby was there. In a default crib :( I give up.

Hmm ok I will give this one more chance. I wrote the code as:

def assign_bassinet_for_baby(sim_info, ignore_daycare=False):
    object_manager = services.object_manager()
    for bassinet in object_manager.get_objects_of_type_gen(*BabyTuning.BABY_BASSINET_DEFINITION_MAP.values()):
        while not bassinet.transient:
            set_baby_sim_info_with_switch_id(bassinet, sim_info, ignore_daycare=ignore_daycare)
            bassinet.destroy(source=sim_info, cause='Assigned bassinet for baby.')
            return True
     definition_ids = 
     for bassinet in object_manager.get_objects_of_def_id_gen(*definition_ids):
        while not bassinet.transient:
            set_baby_sim_info_with_switch_id(bassinet, sim_info, ignore_daycare=ignore_daycare)
            bassinet.destroy(source=sim_info, cause='Assigned bassinet for baby.')
            return True
    return False

I am not a python expert, and I hate trying to work out other people's uncommented python code because the lack of explicit typing makes it hard to work out what exact bit of data the function is expecting, especially when there are no usage examples in the existing python scripts.

"IngeJones;15205732" wrote:
Hmm ok I will give this one more chance. I wrote the code as:

def assign_bassinet_for_baby(sim_info, ignore_daycare=False):
    object_manager = services.object_manager()
    for bassinet in object_manager.get_objects_of_type_gen(*BabyTuning.BABY_BASSINET_DEFINITION_MAP.values()):
        while not bassinet.transient:
            set_baby_sim_info_with_switch_id(bassinet, sim_info, ignore_daycare=ignore_daycare)
            bassinet.destroy(source=sim_info, cause='Assigned bassinet for baby.')
            return True
     definition_ids = 
     for bassinet in object_manager.get_objects_of_def_id_gen(*definition_ids):
        while not bassinet.transient:
            set_baby_sim_info_with_switch_id(bassinet, sim_info, ignore_daycare=ignore_daycare)
            bassinet.destroy(source=sim_info, cause='Assigned bassinet for baby.')
            return True
    return False

I am not a python expert, and I hate trying to work out other people's uncommented python code because the lack of explicit typing makes it hard to work out what exact bit of data the function is expecting, especially when there are no usage examples in the existing python scripts.

I see two problems:

You're calling set_baby_sim_info_with_switch_id() which always attempts to create and assign a new bassinet, so you'll either have to modify that function or just create a new one.

You're destroying your custom bassinet at the end of the loop and you should only do so on failure (or for humor value?).


Sorry for the delay, I hadn't noticed that there was activity in this section. If you're spawning the bassinet with your script, it might also be more efficient to get the instance id from create_object and then assign rather than looping through the object list repeatedly and testing definition IDs.

Well I am just copying the existing loop, which checked for specific instance IDs, which I expect to be falling through when there are no default bassinets on the lot. I have no idea why they have the bassinet.destroy in there, or any of the other bits for that matter lol, so I didn't like to just do without it in case it was needed. The idea is mine just matches on a different criterion, but then should just get on and do exactly the same as the first, exhausted, loop would have done. Obviously if there is a default bassinet, then my bit shouldn't run at all, since it will return True before that bit.

"IngeJones;15209548" wrote:
Well I am just copying the existing loop, which checked for specific instance IDs, which I expect to be falling through when there are no default bassinets on the lot. I have no idea why they have the bassinet.destroy in there, or any of the other bits for that matter lol, so I didn't like to just do without it in case it was needed. The idea is mine just matches on a different criterion, but then should just get on and do exactly the same as the first, exhausted, loop would have done. Obviously if there is a default bassinet, then my bit shouldn't run at all, since it will return True before that bit.

You'd be better off just spawning your custom instance by definition id with create_object() and then updating the return with the baby sim_info. You've probably already noticed that, in nearly every case, it's easier to re-write all of the functions since theirs are never appropriate for any purpose beyond what they've already offered.