I had an issue where my saves were going to OneDrive, I deleted OneDrive as per the thread and the game seemed to be saving to C:\Users\chart\Documents\Electronic Arts\The Sims 4\Recorded Videos\
Then, I noticed the game had installed a pack I had chosen not to download (via the EA app) and I read you cannot remove a single pack so I uninstalled everything and downloaded the game and packs I wanted (making sure to back up my saves and tray items).
My saves weren't showing after this and I eventually found the user files had appeared here: C:\Users\Public\Documents\Electronic Arts\The Sims 4\Recorded Videos\
I want to change the location back to: C:\Users\chart\Documents\Electronic Arts\The Sims 4\Recorded Videos\
EDIT: I should have done this before but I've checked the Documents directory and found it's still listing it as in a OneDrive folder, one that was deleted. I then went into the Registry Editor and checked the user shell folders, modified the locations as some were set to OneDrive and restarted. Opened up Command Prompt andchecked, the Documents directory is still listed as 'Personal REG_SZ C:\Users\chart\OneDrive\Documents'. Could it be that the default is not set? Baring in mind, I do have other (non admin) users, what would it need to be changed to? %USERPROFILE%\ or C:\Users\chart\?
@cnuttah Did you restart your computer after changing the registry value and before running the Command Prompt command again? If not, please do so now.
Sims 4 will use C:\Users\Public when it can't access the user profile's Documents directory, as would be the case if the directory were still in the OneDrive folder but OneDrive itself was removed.
