Sims 4 game crashes when saving and all progress is lost everytime on Xbox one

Okay, I have had a similar problem but mine involved the Error 22.  I found a workaround though and it may help for you as well.  Although I agree that EA needs to fix it ,from what I've found the issue is too many save slots for the same world game.  So what you can try is deleting all but one save slot, go back into the game and give it a go again and see if the issue is resolved.  I created a walkthrough if you want to try it but you need to understand a few things;

1. This walkthrough was designed around the Error 22 issue
2. Although you should lose nothing by following these steps exactly, it does require the deletion of all saves for that world/household.
3. I know it sounds scary to delete every save for a game that you've been playing for a long time, but again you should not lose any data IF YOU FOLLOW THESE STEPS EXACTLY
4. This walkthrough requires you to not have the game running as the very first step is to Load The Sims 4 and that is important for some reason.
5. As I said, I used this and it worked.  Sadly, it is the only thing that I've found that works for the error 22 save issue.

So here's the walkthrough, please let me know if it helps:

WARNING: THIS PROCESS CALLS FOR THE COMPLETE DELETION OF ALL SAVE FILES FOR THIS HOUSEHOLD/WORLD

1. Load The Sims 4
2. Load a saved game (preferably the latest save but not autosave) 
3. Enter household (if you get a warning that some content is missing go to the "Quit Sims 4" steps below then start again with step 1 of this process)
4. Press the menu button
5. Select Save
6. Highlight one of the saves for this household/world
7. Press Y (This is to delete the save)
8. Highlight the checkmark and press A to confirm delete
9. Repeat steps 6 through 8 to delete all saves for this household/world ONCE YOU DO THIS, ALL SAVE GAMES ARE GONE FOR THIS HOUSEHOLD/WORLD
10. Select an empty save slot and save
11.  OMG! OMG! OMG! THE GAME SHOULD BE PLAYABLE AGAIN!!!!!!!

Quit Sims 4

1. Press the Xbox button
2. Highlight The Sims 4
3. Press the menu button
4. Scroll down to and select Quit