Sims file keep saving in C:\Users\Public

badgirlaya  Do you still need help?  The underlying issue is that Windows (probably) still has your Documents directory assigned as Users > your username > OneDrive > Documents.  (Your computer has several Documents folders, as you've seen, but only one is designated as the directory.)  Sims 4 tries to use this location, and if it can't, sometimes it uses the Public Documents folder.

So you'll need to force Documents back to the default location.  Here's how:

https://support.microsoft.com/en-us/topic/operation-to-change-a-personal-folder-location-fails-in-windows-ffb95139-6dbb-821d-27ec-62c9aaccd720

Change only the Personal value, unless you also want to move Desktop and Pictures out of OneDrive and haven't already.