[CL] Sims reset when autonomously using Karaoke Machine during festival

I had the same error in San Myshuno. Whenever a Sim attempted to use the karaoke machine autonomously, they would reset and a Last Exception would be shown in the notifications.

Here's what I found in the LastException.txt file:

Exception in Sim Timeline: Exception running Element (AttributeError:  'JoinSituationElement' object has no attribute 'situation_type')


Traceback (most recent call last):


File "T:\InGame\Gameplay\Scripts\Server\scheduling.py", line 231, in simulate


File "T:\InGame\Gameplay\Scripts\Server\elements.py", line 335, in _run
 

File "T:\InGame\Gameplay\Scripts\Server\interactions\utils\interaction_elements.py", line 177, in _behavior_element


File "T:\InGame\Gameplay\Scripts\Server\situations\tunable.py", line 558, in _do_behavior AttributeError: 'JoinSituationElement' object has no attribute 'situation_type' rtim=0


I looked up the corresponding code mentioned in the LastException.txt file. So, the game says that the JoinSituationElement does not have a 'situation_type' attribute. Instead, it has 'situation'. These are defined in the FACTORY_TUNABLES dictionary in its class definition. 

In the _do_behavior method, there is a portion of code that checks if the local variable 'situation' is None. There is a call to logger.error() that is given self.situation_type as a parameter, but this attribute was never initialized, so this may be what is causing the error. Perhaps self.situation should be passed in instead.

I don't know if my assessment is correct, but if this helps the development team pinpoint the actual error, then I'm happy. 

Thanks for your time!