It would be nice to have a few more specific sports themed Aspirations. I found it a shame BG is limited to just "Bodybuilder".
Some of the sports you've mentioned probably should have been given Aspirations already, to be honest. With how Snowy Escape and Horse Ranch added in Skills and Aspirations for extreme sports and riding, there are some older packs that could have done the same. In City Living we got basketball, but there was no Skill or Aspiration for that. There could have been a career in that! The same goes with soccer in Discover University as well as football and cheerleading in High School Years. Even though there is swimming when pools became Base Game, skating via Seasons and there is definitely bowling in the Bowling Night Stuff pack, your Sim cannot have aspirations or jobs via those either. Though, at the very least bowling is considered a skill.
When it comes to traits, though, some of your suggestions sort of already exist in Base Game and already make sense with most of the sports you've listed.
Personality Trait: Active
Lot Trait: Bracing Breezes
Skills: Fitness
Bonus Aspiration Trait: High Metabolism
Reward Trait: Gym Rat
Perhaps a Venue type suitable would be a "Sports Center"?
A Trait could be "In the game", since all sports require more than just being active. There needs to be focus and tactical skills.
A Lot Trait could probably be "Good Sportsmanship" or "High Morale".