Ideas
A note for the next upcoming fix. Since black photos are a symptom of a bug and not a bug itself, the issue can have many causes and each needs to be fixed separately. The only safe thing you can do is keep backups of your save game and/or upload rooms with your photos to your library or gallery.
This is true for the upcoming patch when they fix another instance. Do not throw your backups away. Keep them safe. You can also keep the files in the screenshot folder in a safe place and then restore them from there if necessary:
https://sims4.crinrict.com/eng/2025/04/custom-photos-in-game-fix-for-black-photos/ (it's a bit of a tedious method and unfortunately doesn't work for console)
You can also find a mini tutorial here: https://www.patreon.com/posts/mini-tutorial-148326243 to restore them from a backup. I haven't personally tested this though.