@tinateen122 The reason your game is generating a new game folder each time it launches is that it can't find any existing folders to use. It can also happen if you rename the existing game folder to something other than "The Sims 4." This is precisely how you generate a clean folder for testing purposes. If you want it to use an existing folder (which you might not right now), you have to put that TS4 folder (the whole thing) into the folder labeled Electronic Arts, inside your Documents folder.
Yes, it's a good idea to leave your iCloud drive disabled for now.
If you're not sure which game folder TS4 is loading, you can copy one of your saves into the folder you want the game to use. (Don't just move it, as you want to keep the original safe from all this fussing.) Right-click on the save, select copy, and then right-click inside the saves folder in appropriate TS4 folder and select paste. When you load the game again, if you see that save available, you'll know that the correct folder is being used. If not, the game probably generated another folder. Go look for that folder and see where it is and how it's labeled; that's the only name and location that TS4 will recognize.
As long as your cc and mods setup looks like the screenshots in the second post I linked above, and the game is loading the appropriate TS4 folder, any usable cc should show up in-game.
I don't think you need the unarchiver app to extract .zip files; that's only for other kinds of compressed files. But either way, double-clicking should extract a .package file. Perhaps it's being sent to another folder (I extract mine in Downloads, which is where the .package files appear). You can try to search in the finder for the name of the file—it should have the same name, or mostly the same name, as the .zip file.
You can take screenshots of what you're seeing by holding down the command and shift keys and pressing 4. Your cursor icon will change, and you can drag it across the field that you want to capture. The screenshot should appear on your desktop. You can attach it here by clicking on the "browse" button next to the paper clip icon just above the "preview" and "submit" buttons when you're typing a reply.